Page tree
Skip to end of metadata
Go to start of metadata

Committer Promotions

While the initial committers on a project are nominated at project formation, it is expected that community members will emerge as willing committers over time.

Committer nomination and promotion must take place according to Section 8 of the TSC Charter. This page intends to describe how the charter shall be interpreted in a practical step by step manner.

Prior to nomination

Project contributors who are interested in promotion to project committer should first approach the project leader and committer community to discuss their interest and receive feedback on their work within the community.
To be promoted to committer the TSC will be looking for the nominated contributors to have demonstrated:

  • A history of active contributions in the project
  • Has demonstrated to the project lead and committer a deep knowledge of the code and project best practices
  • Has shown a willingness to lead and coordinate amongst peers

Once the project lead and committers feel the candidate has demonstrated these items to the point where a nomination may occur the project lead or a delegate may initiate a nomination for committer promotion amongst the projects current committers.

Nomination for committer promotion

via gerrit 

The nomination for committer promotion via gerrit begins with the project lead or delegate pushing a patch adding the proposed committer to the INFO file in the repository. 

The commit message for the patch should begin with a clear topic name and be followed by a statement of motivation. The statement of motivation should describe any achievements or activities the contributor has performed of notable value for the project and may include a link to a git-log of the nominees activity history. It is advised to include only contributor nomination in any one nomination patch.  The review of the patch is to be done on gerrit.opnfv.org; all current committers of the project should be called to review; requiring a majority of committers voting to support the patch (either +1, or +2 are supporting votes) before the nomination evaluation is considered complete and successful. 

Once the patch has a majority of committers supporting it, the PTL should vote +2 if not already done and merge the patch to the repository where the contributor is promoted to committer.

At the completion of a successful nomination process the Project lead should inform the TSC via the TSC mailing list opnfv-tsc@lists.opnfv.org and OPNFV helpdesk at opnfv-helpdesk@rt.linuxfoundation.org by e-mail along with a link to the successful patch.
The e-mail should take the following form:

  • From: <project lead>
  • To: opnfv-tsc@lists.opnfv.org; opnfv-helpdesk@rt.linuxfoundation.org
  • Subject: [project-name] Nomination of Committer(s) promotion for: <contributors name(s)>
  • Body: I would like to inform the TSC that <nominees name> has been added as a committer to the <project-name>. 
       NOTE: Should contain the <commit-message> and a link to the <gerrit-patch>.

via e-mail

The nomination for committer promotion via e-mail begins with the project lead or delegate sending an e-mail to the opnfv-tech-discuss mailing list with the appropriate project identified in the subject line

[project-name]

requesting the committers on the project vote on the nomination.
The nomination e-mail should begin with a clear topic name and be followed by a statement of motivation. The statement of motivation should describe any achievements or activities the contributor has performed of notable value for the project and may include a link to a git-log of the nominees activity history. More than one contributor may be nominated in one nomination e-mail.
The e-mail may take the following form:

  • From: <project lead>
  • To: opnfv-tech-discuss@lists.opnfv.org
  • Subject: [project-name] Nomination of Committer(s) promotion for: <contributors name(s)>
  • Body: The motivation for nominating <contributors name> to committer on the <project> project is due to a long history of providing value to the project through consistent high quality and valuable contributions. <refer to relevant contributions and the value they provided to the project> I provide a link to the relevant contributions. <link>

Once the e-mail has been sent the nomination stands until a clear majority vote for or against the nomination has been met, or the nominator withdraws the nomination. Voting shall take place according to the Condorcet or single transferable vote methods outlined in Section 7 of the TSC charter.

At the completion of a nomination process, if the nominee was successful, the Project lead should inform the TSC via the TSC mailing list opnfv-tsc@lists.opnfv.org by forwarding the nomination e-mail along with a summary of the outcome of the committer votes.

The Project leader should additionally update the "Key Project Facts" section of the project WiKi page as well as the INFO file in the project repository and inform the LinuxFoundation facilities team of the individuals change in status. This should be done by sending an update e-mail to opnfv-helpdesk@rt.linuxfoundation.org with the new committers e-mail and LinuxFoundation ID. This e-mail should either contain a link to the meeting minutes or relevant specific email archive recording the vote.

Contesting a nomination or promotion

The TSC is responsible for overseeing the committer nomination and promotion processes. In the case that any member of the OPNFV community would like to raise discussion or has concerns over a committer promotion, nomination, or the committer promotion process they should reach out to the TSC via the TSC mailing list opnfv-tsc@lists.opnfv.org, or if preferred the TSC Chair Person directly to identify if further action or intervention by the TSC is needed.

  • No labels

4 Comments

  1. seems reasonable to me .

  2. Pardon this question, but I have not see before a "+2" vote described. I thought we only had -1 = no, 0 = abstain, +1 = yes....so +2 = ???

    Any explanation appreciated

    1. Yes. When we vote in TSC we usually use +1/0/-1. Gerrit uses some more options, but only committers can use +2 and -2. +2 by a committer allows a patch be merged. (so gerrit doesn't help us checking whether a majority of committers has approved here). A committer saying -2 to a patch doesn't want to see a patch again - even after some changes. Hope that clarifies.

    2. Hmm, actually that's not a bad point Bob.  While Uli clarified why it is like it is, we should likely not specify a +2 be required to register a positive vote where +1 should be sufficient.  I will make a small amendment where the text is constraining to the point of requiring +2 as that was certainly not my intent when crafting the text.